feat: support inbound plugin jsonschema validator #239
Conversation
cchenggit
force-pushed
the
feat/plugin-jsonschema-validator
branch
from
e24260e to
e613d87
Compare
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
cchenggit
force-pushed
the
feat/plugin-jsonschema-validator
branch
from
d4f58ec to
6166e8d
Compare
| "encoding/hex" | ||
| ) | ||
|
|
||
| func Hash256(s string) string { |
| "time" | ||
| ) | ||
|
|
||
| type Config struct { |
There was a problem hiding this comment.
Requires a version field. (enum: draft4/draft6/draft7/etc..)
There was a problem hiding this comment.
current jsonschema only support openapi3 schema, which based on the draft6
| RawBody: body, | ||
| }) | ||
| if err != nil { | ||
| if validateErr, ok := err.(*errs.ValidateError); ok { |
There was a problem hiding this comment.
Can this be handled inside the plugin?
| } | ||
|
|
||
| type SchemaResource struct { | ||
| JSONString string `json:"json" validate:"omitempty,json,max=1048576"` |
There was a problem hiding this comment.
I prefer to use json:"schema"
| Schemas map[string]*SchemaResource `json:"schemas" validate:"dive,required"` | ||
| } | ||
|
|
||
| type EventTypeSchema struct { |
There was a problem hiding this comment.
I don't see this struct is used.
|
I think we can design a feature to support loading values from external system(including file, env, and network), this would be a different topic. Let's remove the part of loading schema from the file and network to keep the plugin as simple as possible. |
good idea, this should the common requirement of plugin |
|
Please update the README.md to mention this cool plugin. |
issue #227