fix(plugin-meetings): send metric when whiteboard share is stopped #4455
+70
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES SPARK-705847
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-705847
Currently on web app when whiteboards are stopped the client.share.stopped ca event is not sent. This is because Web app does not utilise
stopWhiteboardShare
from the sdk for warhol whiteboards where this event is currently sent. Using this function causes some duplicate requests to be made, and one conflicts, so I'm not going to mess with the implementation and just add the metric to be sent when we get the locus media event that whiteboard share has stopped.by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.