Skip to content

Conversation

jor-row
Copy link
Contributor

@jor-row jor-row commented Aug 29, 2025

COMPLETES SPARK-705847

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-705847

Currently on web app when whiteboards are stopped the client.share.stopped ca event is not sent. This is because Web app does not utilise stopWhiteboardShare from the sdk for warhol whiteboards where this event is currently sent. Using this function causes some duplicate requests to be made, and one conflicts, so I'm not going to mess with the implementation and just add the metric to be sent when we get the locus media event that whiteboard share has stopped.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@jor-row jor-row requested review from a team as code owners August 29, 2025 15:22
@jor-row jor-row added the validated If the pull request is validated for automation. label Aug 29, 2025
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4455.d3m3l2kee0btzx.amplifyapp.com

@Coread Coread enabled auto-merge (squash) September 10, 2025 15:51
@Coread Coread merged commit 619b171 into webex:next Sep 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants