Crash: Add initialize() method to CrashReportStorage #54174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL introduces the `initialize()` method to the `CrashReportStorage` interface, introduced in [1] and [2]. This API gives an asynchronous gap for the implementation to initialize any relevant backing memory for the crash report storage. In the current Chromium implementation, this isn't used since the web APIs `set()` and `remove()` are backed by synchronous IPCs, but this method is required by the spec proposal to allow for more sophisticated mechanisms to be used for the backing memory. In Chromium, we are exploring taking advantage of this in https://crrev.com/c/6788146, where we're considering replacing `RenderFrameHostImpl::crash_storage_map_` with a shared memory region that spans the browser and renderer process. [1]: https://github.com/WICG/crash-reporting/blob/gh-pages/crashReport-explainer.md [2]: WICG/crash-reporting#37 R=creis, dcheng Bug: 400432195 Change-Id: I7ee67d29c6d4601b4d7ecb2d0b54dd24d0111e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819100 Reviewed-by: Steven Holte <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: mmenke <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497721}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6819100
branch
from
15a7505 to
9356575
Compare
wpt-pr-bot
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces the
initialize()method to theCrashReportStorageinterface, introduced in 1 and 2. This API gives an asynchronous gap
for the implementation to initialize any relevant backing memory for the
crash report storage.
In the current Chromium implementation, this isn't used since the web
APIs
set()andremove()are backed by synchronous IPCs, but thismethod is required by the spec proposal to allow for more sophisticated
mechanisms to be used for the backing memory. In Chromium, we are
exploring taking advantage of this in https://crrev.com/c/6788146, where
we're considering replacing
RenderFrameHostImpl::crash_storage_map_with a shared memory region that spans the browser and renderer process.
R=creis, dcheng
Bug: 400432195
Change-Id: I7ee67d29c6d4601b4d7ecb2d0b54dd24d0111e39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819100
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: mmenke <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497721}