Set security context that passes enforce:restricted pod security #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
approved these changes
Sep 23, 2022
I was browsing logs and came across warnings about pod security, which is new in 1.25. We clearly didn't pass the default `restricted` policy. After putting the policy into place, I don't believe there's anything we do that isn't allowed by this policy, so let's run it with security turned on from now on.
ozamosi
force-pushed
the
pod-security
branch
from
f820c99 to
c4e434c
Compare
This was referenced Sep 27, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing logs and came across warnings about pod security, which is new in 1.25. We clearly didn't pass the default
restrictedpolicy.After putting the policy into place, I don't believe there's anything we do that isn't allowed by this policy, so let's run it with security turned on from now on.
To test that we pass this pod security policy, try setting
kubectl label namespace <namespace> pod-security.kubernetes.io/enforce=restrictedagainst the namespace where weave-gitops is running. Before this PR, that would make weave-gitops be rejected.To test that these pod restrictions work, you shouldn't need to do anything - they're always enabled, so if it ever works, it should work both with and without pod security policy enforcement.