Skip to content

[UI] Use useQuery for api calls #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 27, 2022
Merged

[UI] Use useQuery for api calls #960

merged 24 commits into from
Jun 27, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jun 17, 2022

Closes #791

@AlinaGoaga AlinaGoaga marked this pull request as ready for review June 20, 2022 05:55
@AlinaGoaga AlinaGoaga requested review from foot and ahussein3 June 20, 2022 05:55
@@ -221,6 +222,7 @@ const ProfilesProvider: FC = ({ children }) => {
<Profiles.Provider
value={{
loading,
isLoading,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about having this stuff (loading/isLoading) mixed up (don't have to address this in this PR, just for the future..), maybe we wanna keep deprecating contexts?

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@AlinaGoaga AlinaGoaga merged commit a401e48 into main Jun 27, 2022
@AlinaGoaga AlinaGoaga deleted the refactor-api-calls branch June 27, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Use useQuery for api calls
3 participants