-
Notifications
You must be signed in to change notification settings - Fork 2
[UI] Use useQuery for api calls #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into refactor-api-calls
…ps-enterprise into refactor-api-calls
…ps-enterprise into refactor-api-calls
@@ -221,6 +222,7 @@ const ProfilesProvider: FC = ({ children }) => { | |||
<Profiles.Provider | |||
value={{ | |||
loading, | |||
isLoading, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about having this stuff (loading/isLoading) mixed up (don't have to address this in this PR, just for the future..), maybe we wanna keep deprecating contexts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 !
Closes #791