Skip to content

[UI] Applications/Sources pages crash the UI if a cluster cannot be reached #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2022
Merged

[UI] Applications/Sources pages crash the UI if a cluster cannot be reached #920

merged 4 commits into from
Jun 8, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jun 7, 2022 •
edited
Loading

Closes #911

Adapted ErrorBoundary Component from Core. See React example here: https://reactjs.org/docs/error-boundaries.html

Instead of crashing it now shows:

Screenshot 2022-06-07 at 13 16 20

@AlinaGoaga AlinaGoaga added the bug Something isn't working label Jun 7, 2022
@AlinaGoaga AlinaGoaga marked this pull request as ready for review June 7, 2022 13:16
@AlinaGoaga AlinaGoaga requested a review from ahussein3 June 7, 2022 13:16
@ahussein3
Copy link
Contributor

LGTM

@AlinaGoaga AlinaGoaga merged commit 95ee7d5 into main Jun 8, 2022
@AlinaGoaga AlinaGoaga deleted the WG911-add-error-boundary branch June 8, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahussein3 ahussein3 ahussein3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Applications/Sources pages crash the UI if a cluster cannot be reached
2 participants
@AlinaGoaga @ahussein3