-
Notifications
You must be signed in to change notification settings - Fork 2
[UI] Individual cluster page #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
go.mod
Outdated
@@ -1,5 +1,7 @@ | |||
module github.com/weaveworks/weave-gitops-enterprise | |||
|
|||
replace github.com/weaveworks/weave-gitops => /Users/alina/Desktop/projects/weave-gitops/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to local machine link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, if you want to get the BE running locally you'll need to:
- be connected to a cluster (follow instructions in https://github.com/weaveworks/weave-gitops-enterprise/blob/main/CONTRIBUTING.md) from
The private ssh key to the server lives in the pesto test cluster ssh key secret in 1Password.
You'll need to replace the IP that's in there with the newcapd-demo
IP which is35.188.40.143
. - then in another tab start the backend with:
CAPI_CLUSTERS_NAMESPACE=default go run cmd/clusters-service/main.go
Prior to doing this make sure you export the kubeconfig you just downloaded at the previous step; I just save it at the root of the project and export it from there
MacBook-Pro:weave-gitops-enterprise alina$ export KUBECONFIG=demokubeconfig.txt
Ofc don't push it to Github :D
Then to run the frontend:
PROXY_HOST=https://localhost:8000/ yarn start
I have added latest from main and refactor the FilterTable breaking changes that core introduced. Everything else is LGMT |
@foot @ahussein3 Hello! Just to let you know that team denim have just done a Core release so I've updated the code to work with that. Now that the tests are actually running it looks like they will need some further updates since we changed the Cluster Table 😊 . Thank you for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have just one tiny comment.
startIcon={<Icon type={IconType.ExternalTab} size="base" />} | ||
onClick={() => | ||
history.push( | ||
`/applications?filters:clusterName=${currentCluster?.name}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to omit filters:
as a word as it's not indicating any data relating to query params. and we will need to omit it by code later anyway.
- Bring back data-cluster-name attr to do some selecting in acc. tests
Closes #831, #921