Skip to content

[UI] Individual cluster page #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 21, 2022
Merged

[UI] Individual cluster page #917

merged 24 commits into from
Jun 21, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jun 6, 2022

Closes #831, #921

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Jun 6, 2022
@AlinaGoaga AlinaGoaga requested a review from ahussein3 June 14, 2022 16:07
@AlinaGoaga AlinaGoaga marked this pull request as ready for review June 14, 2022 16:14
go.mod Outdated
@@ -1,5 +1,7 @@
module github.com/weaveworks/weave-gitops-enterprise

replace github.com/weaveworks/weave-gitops => /Users/alina/Desktop/projects/weave-gitops/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to local machine link

Copy link
Contributor Author

@AlinaGoaga AlinaGoaga Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, if you want to get the BE running locally you'll need to:

CAPI_CLUSTERS_NAMESPACE=default go run cmd/clusters-service/main.go

Prior to doing this make sure you export the kubeconfig you just downloaded at the previous step; I just save it at the root of the project and export it from there

MacBook-Pro:weave-gitops-enterprise alina$ export KUBECONFIG=demokubeconfig.txt

Ofc don't push it to Github :D

Then to run the frontend:

PROXY_HOST=https://localhost:8000/ yarn start

@ahussein3
Copy link
Contributor

ahussein3 commented Jun 15, 2022

I have added latest from main and refactor the FilterTable breaking changes that core introduced. Everything else is LGMT

@AlinaGoaga
Copy link
Contributor Author

@foot @ahussein3 Hello! Just to let you know that team denim have just done a Core release so I've updated the code to work with that. Now that the tests are actually running it looks like they will need some further updates since we changed the Cluster Table 😊 . Thank you for your help!

Copy link
Contributor

@ahussein3 ahussein3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have just one tiny comment.

startIcon={<Icon type={IconType.ExternalTab} size="base" />}
onClick={() =>
history.push(
`/applications?filters:clusterName=${currentCluster?.name}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to omit filters: as a word as it's not indicating any data relating to query params. and we will need to omit it by code later anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]As a Platform Operator I want to see the labels on my GitOps cluster objects
3 participants