Fix bug when deduplicating the discovered credentials. #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
fix-dedup-credentials
branch
2 times, most recently
from
97f7fc4 to
267cac6
Compare
Credentials were grouped by GVK which means that all resources of the same kind were grouped in to one. Add testing for FindCredentials.
foot
force-pushed
the
fix-dedup-credentials
branch
from
267cac6 to
6fa8dcd
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credentials were grouped by GVK which means that all resources of the
same kind were grouped in to one.
Add testing for FindCredentials.
Fixes: weave-gitops-interlock/issues/127
Fixes: #859