Skip to content

Rename GitopsTemplate to GitOpsTemplate #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 26, 2022

No description provided.

@Skarlso Skarlso added the enhancement New feature or request label May 26, 2022
@Skarlso Skarlso requested review from chanwit and nikimanoledaki May 26, 2022 05:42
@chanwit
Copy link
Member

chanwit commented May 26, 2022

Hmm as we are the GitOps company, so I think GitOps is the correct spelling here and we would change Gitops somewhere else to GitOps instead.

@Skarlso
Copy link
Contributor Author

Skarlso commented May 26, 2022

@chanwit I agree, that's why we had it as GitOps. Sadly, enterprise already has GitopsCluster so others suggested having it consistent with that. ¯\_(ツ)_/¯

@chanwit
Copy link
Member

chanwit commented May 26, 2022

That's a very sad backstory.

@Skarlso
Copy link
Contributor Author

Skarlso commented May 26, 2022

Works!

cat call.json|go run main.go v1/tfcontrollers
read body:  {
    "repository_url": "https://github.com/Skarlso/flux-test-2",
    "base_branch": "main",
    "title": "title",
    "description": "description",
    "template_name": "sample-wge-tf-controller-template",
    "parameter_values": {
        "RESOURCE_NAME": "test-template-tf-1"
    },
    "commit_message": "commit this",
    "repository_api_url": "",
    "template_kind": "GitopsTemplate"
}

resp:  {"webUrl":"https://github.com/Skarlso/flux-test-2/pull/3"}

https://github.com/Skarlso/flux-test-2/pull/3/files

@Skarlso Skarlso changed the title Rename GitOpsTemplate to GitopsTemplate Rename GitopsTemplate to GitOpsTemplate May 26, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented May 26, 2022

In a follow-up PR, I will rename GitopsCluster to GitOpsCluster. But not in this to keep changes to a minimum.

Also, change:

  • handbook about naming
  • weave-gitops -> CLI kind passed in

@chanwit
Copy link
Member

chanwit commented May 26, 2022

Hi @Skarlso
Could we just drop this PR then?

@Skarlso
Copy link
Contributor Author

Skarlso commented May 26, 2022

@chanwit What do you mean? Why? This is now renaming From Gitops to GitOps. :)

@chanwit
Copy link
Member

chanwit commented May 26, 2022

I see.
@Skarlso could you squash the commits so that I can see what's really going on, please?
It's so confusing seeing two commit messages doing the opposite things.

@Skarlso
Copy link
Contributor Author

Skarlso commented May 26, 2022

@chanwit How would squashing change the diff view? 🤔

I'll squash it ofc, I was just wondering. :)

@Skarlso Skarlso force-pushed the fix-gitops-template-name branch from 596068e to 7e330c1 Compare May 26, 2022 12:01
@Skarlso Skarlso force-pushed the fix-gitops-template-name branch from 7e330c1 to 50dcd38 Compare May 26, 2022 12:03
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Skarlso Skarlso merged commit 7af29fe into main May 26, 2022
@Skarlso Skarlso deleted the fix-gitops-template-name branch May 26, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants