Small fixes and tweaks for nightly cluster cleanup #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saeedfazal
commented
May 19, 2022
saeedfazal
commented
- Fixed nightly test failing due to orphan resources from previous day run
- Add capi provider cleanup for cluster reset
- Add explicit CAPI_PROVIDER environment variable to install capi provider to management cluster
- Update the acceptance user guide
saeedfazal
added
the
exclude from release notes
saeedfazal
force-pushed
the
cleanup-nightly-fix
branch
from
18d2eb8 to
9e34f9f
Compare
foot
reviewed
May 20, 2022
| @@ -849,6 +849,7 @@ func DescribeTemplates(gitopsTestRunner GitopsTestRunner) { | |||
| } | |||
|
|
|||
| setParameterValues(createPage, paramSection) | |||
| pages.ScrollWindow(webDriver, 0, 4000) | |||
There was a problem hiding this comment.
Interesting, do we see failures without this?
There was a problem hiding this comment.
yes, rarely one of the nightly test fail being not able to locate the 'Preview PR' button. I found scrolling explicitly fixes the issue.
foot
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.