Remove the SQLite DB, wkp-agent, event-writer and NATS #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
approved these changes
May 19, 2022
We've recently removed support for SQLite database. All state is now held in etcd/k8s. This also deprecates the whole agent model so we can remove that too. NATS and the event-writer were supporting that too.
- Git provider should show an error failing to delete no-existant files from git.
foot
force-pushed
the
remove-the-sqlite-db
branch
from
b6f8d24 to
8cc611a
Compare
foot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771
We've recently removed support for SQLite database. All state is now
held in etcd/k8s.
This also deprecates the whole agent model so we can remove that too.
NATS and the event-writer were supporting that too.
This PR removes all the red bits:
Checklist
Approach
I started off trying to only remove the database / agent etc from the clusters-service to do this a bit more incrementally, but then it all came down..
Mopping up I grep'd the codebase for
agentnatsdatabasedbsqlitegormpostgres/gitops/