feat: #704: process template variables in profile values #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmickey
force-pushed
the
feat/704-template-values
branch
5 times, most recently
from
e98d22a to
ae98aca
Compare
bigkevmcd
reviewed
May 18, 2022
jmickey
force-pushed
the
feat/704-template-values
branch
from
ae98aca to
293eb07
Compare
foot
approved these changes
May 20, 2022
| @@ -492,7 +493,7 @@ func createProfileYAML(helmRepo *sourcev1.HelmRepository, helmReleases []*helmv2 | |||
| // profileValues is what the client will provide to the API. | |||
| // It may have > 1 and its values parameter may be empty. | |||
| // Assumption: each profile should have a values.yaml that we can treat as the default. | |||
| func generateProfileFiles(ctx context.Context, helmRepoName, helmRepoNamespace, helmRepositoryCacheDir, clusterName string, kubeClient client.Client, profileValues []*capiv1_proto.ProfileValues) (*gitprovider.CommitFile, error) { | |||
| func generateProfileFiles(ctx context.Context, helmRepoName, helmRepoNamespace, helmRepositoryCacheDir, clusterName string, kubeClient client.Client, profileValues []*capiv1_proto.ProfileValues, parameterValues map[string]string) (*gitprovider.CommitFile, error) { | |||
There was a problem hiding this comment.
Don't have to address this here, but this arg list is getting very long innit.
There was a problem hiding this comment.
I think as part of getting rid of the deep viper calls, we'll get structs of config, which will simplify this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to use template variables within profile values. WGE will decode and render the variables before parsing them into the profile
HelmRelease.Closes #704