feat: Add cluster-controller chart as a dependency #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
add-cluster-controller-to-helm-chart
branch
4 times, most recently
from
db8ae60 to
50907c5
Compare
yiannistri
force-pushed
the
add-cluster-controller-to-helm-chart
branch
from
50907c5 to
637bebc
Compare
foot
reviewed
Apr 25, 2022
yiannistri
force-pushed
the
add-cluster-controller-to-helm-chart
branch
2 times, most recently
from
1ed8e95 to
4fad68e
Compare
foot
reviewed
Apr 26, 2022
| kind: ServiceAccount | ||
| metadata: | ||
| # Removed `-controller-manager` suffix to simplify name | ||
| name: {{ include "cluster-controller.fullname" . }} |
There was a problem hiding this comment.
Is this a local tweak to the helm output?
There was a problem hiding this comment.
Correct, after running make helm on the cluster-controller repo the Helm chart is generated and copied here. make helm overwrites any files so this will cause a diff next time it runs.
yiannistri
force-pushed
the
add-cluster-controller-to-helm-chart
branch
from
4fad68e to
b7fd886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646
cluster-controllerchart is now a dependency of WGE