Skip to content

Allow configuration of the clusters workloads path #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

foot
Copy link
Collaborator

@foot foot commented Apr 21, 2022

  • E.g. where the clusters-service will write the profiles.yaml that will
    be installed onto the newly created capi cluster when it starts up.

Fixes #642

Now in values.yaml

  • repositoryPath: ./clusters/management/clusters - existing config value to write out my-capi-cluster.yaml under
  • repositoryClustersPath: ./clusters - new config value to write ./my-capi-cluster/profiles.yaml under
    • (This was previously hard-coded to ./.weave-gitops/clusters/my-capi-cluster/system/profiles.yaml)

- E.g. where the clusters-service will write the profiles.yaml that will
  be installed onto the newly created capi cluster when it starts up.
@foot foot added the enhancement New feature or request label Apr 21, 2022
@foot
Copy link
Collaborator Author

foot commented Apr 21, 2022

I don't love the names, lemme know if you think of something better..

Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@foot foot merged commit 1cdaa98 into main Apr 21, 2022
@foot foot deleted the adds-configuration-of-capi-workload-path branch April 21, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap-controller adds profiles.yaml to .weave-gitops folder irrespective of the --path argument set in config file
2 participants