Skip to content

Connect ListGitopsClusters up to the server #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Conversation

foot
Copy link
Collaborator

@foot foot commented Apr 20, 2022

  • Adds the schemas to the clientGetter
  • Adds additional fields to GET /v1/clusters response:
    • secretName, capiClusterName, status, namespace
  • add some tests for the various forms of GitopsCluster

@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Apr 20, 2022
- Adds the schemas to the clientGetter
- Adds additional fields to GET /v1/clusters response:
  - secretName, capiClusterName, status, namespace
@foot foot force-pushed the connect-up-list-clusters branch from 8fd9a95 to 0ff829d Compare April 27, 2022 14:56
Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇 🎉

@foot foot merged commit 7e452cd into main Apr 28, 2022
@foot foot deleted the connect-up-list-clusters branch April 28, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants