Skip to content

Add a root route to serve the ui from the clusters-service #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 3, 2022
Merged

Add a root route to serve the ui from the clusters-service #463

merged 19 commits into from
Feb 3, 2022

Conversation

sarataha
Copy link
Member

@sarataha sarataha commented Feb 2, 2022

Part of #406

@sarataha sarataha added the enhancement New feature or request label Feb 2, 2022
foot
foot reviewed Feb 2, 2022
View reviewed changes
foot
foot reviewed Feb 2, 2022
View reviewed changes
sarataha and others added 2 commits February 2, 2022 19:31
foot
foot reviewed Feb 2, 2022
View reviewed changes
@sarataha sarataha marked this pull request as ready for review February 3, 2022 10:12
foot
foot approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try and add some basic tests around the UI! Does core have any inspiration? We could do that in a follow up to unblock #461

@foot foot merged commit f31e7dc into main Feb 3, 2022
@foot foot deleted the add-cluster-service-ui-route branch February 3, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarataha @foot