Skip to content

Checking failure notification just before creating PR #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2022
Merged

Checking failure notification just before creating PR #451

merged 2 commits into from
Jan 28, 2022

Conversation

saeedfazal
Copy link
Contributor

@saeedfazal saeedfazal commented Jan 27, 2022 •
edited
Loading

  • Checking and dismissing error notification just before creating PR
  • Temporary skipping one test for gitlab provider due to resetting of Gitops section after oauth redirection

@saeedfazal saeedfazal self-assigned this Jan 27, 2022
@saeedfazal saeedfazal force-pushed the on-prem-failure-error-notification branch from 37ee779 to fb217d9 Compare January 27, 2022 16:00
@saeedfazal saeedfazal force-pushed the on-prem-failure-error-notification branch from d3f24c9 to d362c4a Compare January 27, 2022 17:34
foot
foot approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@saeedfazal saeedfazal merged commit 3ad272c into main Jan 28, 2022
@saeedfazal saeedfazal deleted the on-prem-failure-error-notification branch January 28, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saeedfazal @foot