Skip to content

add acceptance_test wrok folw to be called from main #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

add acceptance_test wrok folw to be called from main #431

merged 1 commit into from
Jan 17, 2022

Conversation

saeedfazal
Copy link
Contributor

  • Adding acceptance-test.yaml called workflow before caller CI workflow
    USAGE:
    uses: weaveworks/weave-gitops-enterprise/.github/workflows/acceptance-test.yaml@main

@saeedfazal saeedfazal added the exclude from release notes Use this label to exclude a PR from the release notes label Jan 17, 2022
@saeedfazal saeedfazal self-assigned this Jan 17, 2022
foot
foot approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

.github/workflows/acceptance-test.yaml Outdated
default: sqlite
required: false
type: string
artefacts-base-dir:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤏 gh prefers artifacts I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to artifacts

@saeedfazal saeedfazal force-pushed the add_acceptance_test_workflow branch from c3abc89 to a534a3f Compare January 17, 2022 16:58
@saeedfazal saeedfazal force-pushed the add_acceptance_test_workflow branch from a534a3f to 2c11c6d Compare January 17, 2022 17:44
@saeedfazal saeedfazal merged commit bb7fa63 into main Jan 17, 2022
@saeedfazal saeedfazal deleted the add_acceptance_test_workflow branch January 17, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saeedfazal @foot