Convert git to https api endpoints #426
Conversation
| @@ -1,6 +1,6 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.27.1 | |||
| // protoc-gen-go v1.26.0 | |||
There was a problem hiding this comment.
Update buf and re-run cd cmd/clusters-service && make install to get the current versions of things!
| @@ -159,6 +161,8 @@ message DeleteClustersPullRequestRequest { | |||
| string commit_message = 7; | |||
| // Credentials | |||
| Credential credentials = 8; | |||
| // The repo api url. | |||
| string repository_api_url = 9; | |||
There was a problem hiding this comment.
Just curious, why do we accept it in the request and also send it back in the response?
There was a problem hiding this comment.
My mistake, I think we should receive it in request only and if supplied we should ignore creating scm client. Thank you very much for noticing 🙂
cmd/clusters-service/pkg/git/git.go
Outdated
| @@ -79,7 +83,12 @@ type CloneRepoToTempDirResponse struct { | |||
| // It returns the URL of the pull request. | |||
| func (s *GitProviderService) WriteFilesToBranchAndCreatePullRequest(ctx context.Context, | |||
| req WriteFilesToBranchAndCreatePullRequestRequest) (*WriteFilesToBranchAndCreatePullRequestResponse, error) { | |||
| repo, err := s.GetRepository(ctx, req.GitProvider, req.RepositoryURL) | |||
| apiEndpoint, err := getSCMClient(req.GitProvider, req.RepositoryURL) | |||
There was a problem hiding this comment.
How do you think about renaming apiEndpoint to something else since it's an object of *scm.Client?
cmd/clusters-service/pkg/git/git.go
Outdated
| repo, err := s.GetRepository(ctx, req.GitProvider, req.RepositoryURL) | ||
| apiEndpoint, err := getSCMClient(req.GitProvider, req.RepositoryURL) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to get api endpoint: %w", err) |
There was a problem hiding this comment.
Similarly here, is it the endpoint or the client that we fail to retrieve?
There was a problem hiding this comment.
Right! It should be the client 👍
cmd/clusters-service/pkg/git/git.go
Outdated
| @@ -293,3 +301,22 @@ func getGitProviderClient(gpi GitProvider) (gitprovider.Client, error) { | |||
| } | |||
| return client, err | |||
| } | |||
|
|
|||
| func getGitProviderUrl(giturl string) (string, error) { | |||
There was a problem hiding this comment.
Wicked! 🚀 , lets add a couple of tests w/ the diff variations
Closes #401