fix cluster name for eks and gke clusters #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
approved these changes
Jan 4, 2022
| @@ -88,7 +88,7 @@ function setup { | |||
| --set "nginx-ingress-controller.service.nodePorts.http=${UI_NODEPORT}" \ | |||
| --set "config.capi.repositoryURL=${GIT_REPOSITORY_URL}" \ | |||
| --set "config.capi.repositoryPath=./management" \ | |||
| --set "config.cluster.name=$(kubectl config current-context)", \ | |||
| --set "config.cluster.name=$(kubectl config get-clusters | grep $MANAGEMENT_CLUSTER_NAME | sed s/_/-/g)", \ | |||
There was a problem hiding this comment.
This should be the same as whatever gitops install uses to generate secret names etc... I forget what breaks if the gitops cluster name and EE cluster names differ. but it might be better to rename the context using this trick before running gitops install and keep current-context instead.
That said if this seems to work then all good!
There was a problem hiding this comment.
Fixed renaming the context before running gitops install.
saeedfazal
force-pushed
the
fix_nightly_failling_ui_app_add_test
branch
from
f586383 to
3ed6af6
Compare
saeedfazal
force-pushed
the
fix_nightly_failling_ui_app_add_test
branch
from
3ed6af6 to
080a1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #398