Skip to content

Fix Template Credentials in the UI / Turn on typechecking of UI code #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Dec 8, 2023

Closes #3703

What changed?

Why was this change made?

  • We were not typechecking in CI
  • So we missed a big bug.

How was this change implemented?

  • types types types

How did you validate the change?

  • Check ui-unit-tests job, it now typechecks as well as lints

Manually:

@foot foot added the bug Something isn't working label Dec 8, 2023
@foot foot changed the title Turn on typechecking of UI code Fix Template Credentials in the UI / Turn on typechecking of UI code Dec 8, 2023
@foot foot force-pushed the defensive-tf-handling branch from 03d2e16 to 53f32f2 Compare December 8, 2023 14:08
@foot foot marked this pull request as ready for review December 8, 2023 14:10
@foot foot requested a review from opudrovs December 8, 2023 14:28
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have context for this 🐛 (except for the issue description), but code LGTM.

@foot foot merged commit 0ca133e into main Dec 11, 2023
@foot foot deleted the defensive-tf-handling branch December 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template credentials do not load in the UI
2 participants