Skip to content

Add subpath/route-prefix support #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Dec 5, 2023
Merged

Add subpath/route-prefix support #3671

merged 41 commits into from
Dec 5, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Nov 23, 2023

Closes #3440

Using:

What changed?

Enables support for running under weave-gitops-enterprise under a subpath e.g. example.com/weave-gitops-enterprise/ in the UI router

Why was this change made?

Possibility to expose weave-gitops-enterprise dashboard under subpaths.

How was this change implemented?

See comments in Core weaveworks/weave-gitops#3992 (subpath PR in Core)

How did you validate the change?

TBD: test with Ingress (brought over the script to create a kind cls with ingress however we need to adjust the tilt startup script to use this one rather than the standard wge-dev).

  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?

Unit tests can be found in Core for the utils used in EE which we import from there.

Release notes

Documentation Changes

Add a website/docs/enterprise/getting-started/run-ui-subpath.mdx for EE in docs.
weaveworks/weave-gitops#4156

Other follow ups

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Nov 23, 2023
@AlinaGoaga AlinaGoaga marked this pull request as ready for review November 28, 2023 17:07
@foot
Copy link
Collaborator

foot commented Nov 30, 2023

🔥 !

  • GitAuth needs to be pulled in too I think
  • nitpicking on the names const { clustersService } = useEnterpriseClients()? idk, wdyt?

Tested ingress though w/ INSTALL_NGINX_INGRESS=1 DELETE_GITOPS_DEV_REPO=1 ./tools/reboot.sh

and tilt up

and http://localhost:30080/weave-gitops-enterprise and it all works 🎉

@foot
Copy link
Collaborator

foot commented Dec 4, 2023

🔥 ! Working great

  • added some tweaks to get gitlab PRs working.
  • added some more withBasePaths around the place where I could see window.location being used, not sure if we need those error handlers anymore though.

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AlinaGoaga AlinaGoaga merged commit 4c0cd5f into main Dec 5, 2023
@AlinaGoaga AlinaGoaga deleted the subpath-support branch December 5, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subpath/route-prefix support to EE
2 participants