-
Notifications
You must be signed in to change notification settings - Fork 2
Add subpath/route-prefix support #3671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the route prefix + script to create a kind cls with ingress
…enterprise into subpath-support
…calls + update tests
…calls + update tests - 2
🔥 !
Tested ingress though w/ and and http://localhost:30080/weave-gitops-enterprise and it all works 🎉 |
🔥 ! Working great
|
foot
reviewed
Dec 4, 2023
…enterprise into subpath-support
foot
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3440
Using:
What changed?
Enables support for running under weave-gitops-enterprise under a subpath e.g. example.com/weave-gitops-enterprise/ in the UI router
Why was this change made?
Possibility to expose weave-gitops-enterprise dashboard under subpaths.
How was this change implemented?
See comments in Core weaveworks/weave-gitops#3992 (subpath PR in Core)
How did you validate the change?
additionalArgs
intools/dev-values.yaml
tilt up
TBD: test with Ingress (brought over the script to create a kind cls with ingress however we need to adjust the tilt startup script to use this one rather than the standard wge-dev).
Integration tests -- what is covered, what cannot be covered;
or, explain why there are no new tests
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
Unit tests can be found in Core for the utils used in EE which we import from there.
Release notes
Documentation Changes
Add a
website/docs/enterprise/getting-started/run-ui-subpath.mdx
for EE in docs.weaveworks/weave-gitops#4156
Other follow ups