Support dark mode on Explorer pagination controls #3630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
reviewed
Nov 13, 2023
| })` | ||
| ${Icon} .MuiSvgIcon-root { | ||
| color: ${props => | ||
| props.theme.mode === ThemeTypes.Dark ? 'white' : 'unset'}; |
There was a problem hiding this comment.
❔Could we use props.theme.colors.white or smth. like that here instead of the hardcoded white? Not sure about preferred enterprise color conventions.
jpellizzari
force-pushed
the
3612-exp-dark
branch
from
e07bee0 to
d46cd4f
Compare
jpellizzari
force-pushed
the
3612-exp-dark
branch
from
d46cd4f to
ea3e308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3612
Adds support for dark mode on pagination controls in Explorer.