Skip to content

[UI/BE] Add Gitlab support for Create/Delete Cluster #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 88 commits into from
Jan 11, 2022
Merged

[UI/BE] Add Gitlab support for Create/Delete Cluster #361

merged 88 commits into from
Jan 11, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Nov 30, 2021

To test Gitlab Auth:

  • set up a Gitlab app (add the relevant redirect URI) and grab the client id and secret
  • start the clusters service with CAPI_CLUSTERS_NAMESPACE=default CAPI_TEMPLATES_NAMESPACE=default GITLAB_CLIENT_ID=xxx GITLAB_CLIENT_SECRET=yyy GIT_PROVIDER_TYPE=gitlab GIT_PROVIDER_HOSTNAME=gitlab.com CAPI_TEMPLATES_REPOSITORY_URL=https://gitlab.com/alina48/test-alina CAPI_TEMPLATES_REPOSITORY_BASE_BRANCH=main ENTITLEMENT_SECRET_NAMESPACE=wego-system ENTITLEMENT_SECRET_NAME=weave-gitops-enterprise-credentials WEAVE_GITOPS_FLUX_BIN_PATH=$(which flux) go run cmd/clusters-service/main.go

In this PR:

  • added an endpoint to return repo URL (/config)
  • PR Preview becomes optional (steps nav updated also, gitops is on screen from the start)
  • refactoring of profiles (taking them out of the react json schema wrapper)
  • implement Gitlab Auth support
  • refactoring of GitAuth components and flow to allow data to persist on screen whilst the auth is in process
  • library updated to 0.5.1
  • removed the PR Preview acceptance tests temporarily (Saeed will rewrite them when back from holiday)

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Dec 1, 2021
AlinaGoaga and others added 26 commits December 1, 2021 10:48
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🎉 !!!

Thanks for all your hard work on this 💪

@AlinaGoaga AlinaGoaga merged commit da50222 into main Jan 11, 2022
@AlinaGoaga AlinaGoaga deleted the WG347 branch January 11, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants