Skip to content

[UI] Dropdown menus broken in dark-mode #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Nov 7, 2023

Closes #3601

What changed?
change bg-color & onHover bg in dark-mode for Dropdown

redirect3-2023-11-07_14.19.28.mp4

@TheGostKasper TheGostKasper added bug Something isn't working area/ui labels Nov 7, 2023
@TheGostKasper TheGostKasper requested review from foot and joshri November 7, 2023 12:26
@@ -107,7 +107,17 @@ const GlobalStyle = createGlobalStyle`
.MuiFormControl-root {
min-width: 0px;
}

.MuiPaper-root{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯, good spot! This also fixes:

  • template > preview
  • clusters > connect-a-cluster help dialog

@TheGostKasper TheGostKasper merged commit 4b99d83 into main Nov 7, 2023
@TheGostKasper TheGostKasper deleted the 3601-fix-darkmode-dropdown branch November 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menus broken in dark-mode, e.g. "view pull requests"
2 participants