Skip to content

[UI] Update Create Cluster Form (toggle visibility of repeated fields) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 128 commits into from
Dec 2, 2021
Merged

[UI] Update Create Cluster Form (toggle visibility of repeated fields) #353

merged 128 commits into from
Dec 2, 2021

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Nov 26, 2021 •
edited by foot
Loading

Reopening the create cluster form update PR to include the recent work on children visibility when typing in form fields.

  • excludes the sections where there aren't any form fields to fill in
  • only displays the first child of a specific kind and allows the user to toggle the other childrens' visibility
  • displays, per section, how many fields are hidden

Fixes #273

yiannistri and others added 30 commits October 18, 2021 15:45
@yiannistri
Add new /v1/profiles endpoint
5725e87
@yiannistri
Implement options pattern to reduce number of arguments in RunInProce…
7062f07 
…ssGateway
@yiannistri
Add charts package
16b562b
@yiannistri
Add chart tests
c15143e
@yiannistri
Wire in profile helm repository
3fa524b
@AlinaGoaga
WG196 Create profiles context and prelim section in form and nav
590510d
@AlinaGoaga
WG196 Select profiles dropdown WIP
766be32
@AlinaGoaga
WG196 Select profiles dropdown WIP2
0e99316
@yiannistri
Return profiles response
8bc7b24
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
b30a0d1 
…into WG196-cluster-create-profile
@AlinaGoaga
Merge branch 'get-profiles' of github.com:weaveworks/weave-gitops-ent…
2dc1af8 
…erprise into WG196-cluster-create-profile
@AlinaGoaga
Comment out some dependencies to stop continuous loop
96a9d98
@AlinaGoaga
WG196 Yaml preview - WIP
055fe43
@AlinaGoaga
WG196 Yaml preview - WIP2
9480b00
@AlinaGoaga
WG196 Preview dialog - updated
add7617
@AlinaGoaga
WG196 Update yaml content - WIP
5254fa5
@AlinaGoaga
Solve conflicts with master
1b403e1
@AlinaGoaga
WG196 Get/update yaml content for profiles
10de0af
@AlinaGoaga
WG196 Get/update yaml content for profiles - updated
32d8289
@AlinaGoaga
WG196 Update add cluster payload
a1075c4
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
a9ee3fe 
…into WG196-cluster-create-profile
@AlinaGoaga
Fix bug on refresh create form
e926b21
@foot
fixes request param
27b3930
@foot
Merge remote-tracking branch 'origin/main' into WG196-cluster-create-…
d295a8b 
…profile
@foot
rm foot.github
b32e583
@foot
where that typeinfo at
f5bde0e
@foot
wip
0793c96
@AlinaGoaga
WG196 Include defaults when profiles are selected
576c337
@AlinaGoaga
WG196 Updated profiles doesnt update properly - WIP
4a0022a
@AlinaGoaga
WG196 Updated profiles updates correctly following changes in profile…
47b7c57 
… selection
@AlinaGoaga
Fix some more tests
d5b0167
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
f80247a 
…into WG273-rearrange-form-fields
@AlinaGoaga
WG273 Update toggle show-hide form fields
2300437
@AlinaGoaga
Target children which aren't the first in their list
b37ee3e
@AlinaGoaga
WG273 Switch to show fields when user is typing
e029f0b
@AlinaGoaga
WG273 Update style of disabled children
2b3cf40
@AlinaGoaga
Refactor children visibility
41cf60a
@AlinaGoaga
Implement feedback - exclude sections where no user input is necessar…
5a569bb 
…y from the form
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
b2889fb 
…into WG273-rearrange-form-fields
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
838d68d 
…into WG273-rearrange-form-fields
@AlinaGoaga
Update step title to show the no of hidden fields
e0570e5
@AlinaGoaga
Exp with some useMemos
d182383
@AlinaGoaga
Move checking visibility to parent
27285dd
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
a73f937 
…into more-form-refactoring
@AlinaGoaga
Form rerenders on uiSchema update
51376ca
@AlinaGoaga
Move doGrouping back to Grouped Schema
2bd4b69
@foot foot self-requested a review December 1, 2021 09:00
foot
foot approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for all your hard work on this one!

@AlinaGoaga AlinaGoaga merged commit 4feeb69 into main Dec 2, 2021
@AlinaGoaga AlinaGoaga deleted the WG273-refactor-form branch December 2, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Hide repeat fields in Cluster Create Form
3 participants
@AlinaGoaga @foot @yiannistri