-
Notifications
You must be signed in to change notification settings - Fork 2
Add playwright tests job #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add playwright tests job #3521
Changes from 22 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
57598ab
add playwright smoke tests job
taghreed86 d477ee8
add playwright tests job to test.yaml file
taghreed86 cd536ba
fix syntax errors
taghreed86 e0a97c1
add to test.yaml
taghreed86 f0ef904
fix test.yaml
taghreed86 e143dc5
remove the new job from test.yaml
taghreed86 db183e0
add new lines
taghreed86 00f6216
fix indentation in deploy.yaml file
taghreed86 53170b0
restructure playwright smoke tests job
taghreed86 2003281
update github_token value
taghreed86 b80aec8
update repo value
taghreed86 3ccff23
updaye workflow path
taghreed86 12b439c
update workflow_file_name value
taghreed86 efa83fa
add needs section to the playwright job
taghreed86 fbb5263
restructure the playwright tests job
taghreed86 c4178ef
update needs section
taghreed86 95a20f5
added token
enekofb 2527726
remove needs section
taghreed86 19fcae4
update repo name and remove needs section
taghreed86 57624ab
remove the wait_interval parameter
taghreed86 d9d0b73
return wait_interval parameter
taghreed86 6374f47
Merge branch 'main' into add_playwright_tests_job
taghreed86 da14580
Merge branch 'main' into add_playwright_tests_job
taghreed86 56622f6
get chart version
taghreed86 ac83d26
Merge branch 'main' into add_playwright_tests_job
taghreed86 29eec5b
modify the playwright-smoke-tests and remove notify-failure option
taghreed86 0584f84
Merge branch 'main' into add_playwright_tests_job
taghreed86 23adbc2
add coverage in needs section
taghreed86 7f846eb
small typo
enekofb 22fe775
Merge branch 'main' into add_playwright_tests_job
taghreed86 4d71911
remove coverage
taghreed86 64ba070
add continue-on-error: true parameter
taghreed86 5b05352
remove playwright tests from smoke-test-results
taghreed86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,10 +153,26 @@ jobs: | |
WGE_GITLAB_CLIENT_ID: ${{ secrets.WGE_ON_PREM_GITLAB_CLIENT_ID }} | ||
WGE_GITLAB_CLIENT_SECRET: ${{ secrets.WGE_ON_PREM_GITLAB_CLIENT_SECRET }} | ||
|
||
playwright-smoke-tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Run palywright tests workflow | ||
uses: convictional/[email protected] | ||
with: | ||
owner: weaveworks | ||
repo: playwright-tests | ||
github_token: ${{ secrets.BUILD_BOT_PERSONAL_ACCESS_TOKEN }} | ||
workflow_file_name: nightly.yaml | ||
ref: main | ||
wait_interval: 10 | ||
propagate_failure: false | ||
trigger_workflow: true | ||
wait_workflow: true | ||
|
||
smoke-test-results: | ||
if: ${{ always() }} | ||
needs: | ||
[smoke-tests-github, smoke-tests-gitlab-deploy, smoke-tests-gitlab-tenant] | ||
[smoke-tests-github, smoke-tests-gitlab-deploy, smoke-tests-gitlab-tenant, playwright-smoke-tests] | ||
uses: ./.github/workflows/publish-test-results.yaml | ||
with: | ||
runs-on: ubuntu-latest | ||
|
@@ -169,7 +185,7 @@ jobs: | |
notify-failure: | ||
name: Notify Slack on Failure | ||
runs-on: ubuntu-latest | ||
needs: [smoke-tests-github, smoke-tests-gitlab-deploy, smoke-tests-gitlab-tenant] | ||
needs: [smoke-tests-github, smoke-tests-gitlab-deploy, smoke-tests-gitlab-tenant, playwright-smoke-tests] | ||
taghreed86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if: ${{ failure() && github.ref == 'refs/heads/main' }} | ||
steps: | ||
- name: Send alert | ||
|
@@ -180,3 +196,5 @@ jobs: | |
slack-text: | | ||
:sad-parrot: The <https://github.com/weaveworks/weave-gitops-enterprise/commit/${{ github.sha }}|latest commit> from ${{ github.actor }} is failing on main. <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|Click here> and weep. Then fix the underlying issue and ensure main remains green. | ||
slack-optional-icon_url: "https://avatars.githubusercontent.com/u/9976052" | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,3 +136,4 @@ jobs: | |
run: yarn lint | ||
- name: Run Front-end Unit Tests | ||
run: yarn test | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.