Skip to content

Fix console warnings when running ui tests #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Sep 15, 2023

Closes #3581

What changed?

Fixes console warnings when running tests

Screenshot 2023-09-15 at 13 29 14

@AlinaGoaga AlinaGoaga added the exclude from release notes Use this label to exclude a PR from the release notes label Sep 15, 2023
@@ -152,6 +152,7 @@ describe('Auth redirect', () => {
beforeEach(() => {
api = new PipelinesClientMock();
wrap = withContext([...defaultContexts(), [PipelinesProvider, { api }]]);
jest.spyOn(console, 'error').mockImplementationOnce(() => {});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this is coming from the library and it's something that we indeed see in the console as well when we're trying to retrieve objects but the token has expired. I've hidden it here to reduce noise

@AlinaGoaga AlinaGoaga changed the title Fix tests warnings Fix console warnings when running ui tests Sep 15, 2023
@AlinaGoaga AlinaGoaga marked this pull request as ready for review September 15, 2023 11:33
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 🎉

@AlinaGoaga AlinaGoaga merged commit fb3f5bb into main Sep 15, 2023
@AlinaGoaga AlinaGoaga deleted the fix-tests-warnings branch September 15, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants