updating extend explorer internal documentation out of the feedback from adding gitopssets #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
added
the
exclude from release notes
ranatrk
approved these changes
Sep 4, 2023
foot
reviewed
Sep 5, 2023
| If you would like to use default Explorer view with your Kind: | ||
|
|
||
| 1. Add your Kind details Route to [`getKindRoute`](https://github.com/weaveworks/weave-gitops-enterprise/blob/f36d549b6010afbd3c086c4955637586629ec589/ui-cra/src/utils/nav.ts#L3) | ||
| 2. Add a test case for your kind in the [integration test](https://github.com/weaveworks/weave-gitops-enterprise/blob/main/pkg/query/server/server_integration_test.go#L44) | ||
|
|
||
| ## Using the Explorer UI component |
There was a problem hiding this comment.
Maybe a new section:
updating the tests!
- Add any CRDs to testdata/crds
- Add
AddToSchemeto suite_test.go`
Anything else @ranatrk ? 🤔
jpellizzari
approved these changes
Sep 5, 2023
enekofb
force-pushed
the
issues/3281
branch
2 times, most recently
from
cab3ab2 to
2dd6da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rom adding gitopssets
Closes #3281
What changed?
Updated extend explorer internal documentation with findings from extending explorer with gitopsssets
Why was this change made?
To give more complete feedback on the steps to extend explorer
How was this change implemented?
Just documentation
How did you validate the change?
or, explain why there are no new tests
there tests that fail without the change?
It is just documentation so not required the steps above
Release notes
No
Documentation Changes
Not required, internal documentation
Other follow ups