Fix unclear error message when connecting cluster #281
Conversation
| @@ -146,7 +146,8 @@ func RegisterCluster(db *gorm.DB, validate *validator.Validate, unmarshalFn Unma | |||
| err = validate.Struct(crr) | |||
| if err != nil { | |||
| log.Errorf("Failed to validate payload: %v", err) | |||
| common.WriteError(w, ErrInvalidPayload, http.StatusBadRequest) | |||
| combinedError := fmt.Errorf("%v, %v", ErrInvalidPayload, "Error parsing 'url' in field 'Ingress URL'") | |||
There was a problem hiding this comment.
Nice! It be interesting to test the output from the validator too. From:
https://github.com/go-playground/validator/#error-return-value
it says we should cast to validation errors after the nil check to get the actual validation error which might be useful too wdyt?
There was a problem hiding this comment.
Makes sense! Thank you so much 🙏 I tried this at first but thought it was too long so I used a shorter error message but it's better to pass the validation error of course 👍 🙂
There was a problem hiding this comment.
Ah hah! What does it look like? A bit crazy?
There was a problem hiding this comment.
This is for the url string: Key: 'ClusterUpdateRequest.IngressURL' Error:Field validation for 'IngressURL' failed on the 'url' tag 👌
And this is for the ID 🤔: strconv.ParseUint: parsing \"\": invalid syntax
There was a problem hiding this comment.
Ooft! Alright I take it back that error is a bit rough. Your shorter one is much better. Maybe we go back to that one?
Thanks for testing!
There was a problem hiding this comment.
Sure! Thank you very much for reviewing Simon 🙏 🙂
Fixes: #150