Skip to content

Allow creation of secrets needed for listing applications #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Allow creation of secrets needed for listing applications #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a969cab
Allow creation of secrets needed for listing applications
foot Nov 9, 2021
5a28e05
renam
foot Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...s-service/clusters_service_viewer_rb.yaml → ...-service/clusters_service_secrets_rb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: clusters-service-viewer-role
name: clusters-service-secrets-role
namespace: {{ .Values.config.capi.clusters.namespace }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: clusters-service-viewer-role
name: clusters-service-secrets-role
subjects:
- kind: ServiceAccount
name: {{ include "mccp.serviceAccountName" . }}
Expand All @@ -15,12 +15,12 @@ subjects:
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: clusters-service-viewer-role-default
name: clusters-service-secrets-role-default
namespace: {{ .Release.Namespace | quote }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: clusters-service-viewer-role
name: clusters-service-secrets-role
subjects:
- kind: ServiceAccount
name: {{ include "mccp.serviceAccountName" . }}
Expand Down
6 changes: 4 additions & 2 deletions ...es/rbac/clusters_service_viewer_role.yaml → ...s/rbac/clusters_service_secrets_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: clusters-service-viewer-role
name: clusters-service-secrets-role
rules:
- apiGroups: [""]
resources: ["secrets"]
verbs: ["get", "watch", "list"]
# create to create deploy key secrets
# read to read capi secrets like kubeconfig
verbs: ["create", "get", "watch", "list"]