Skip to content

Fixes branch ref for new build workflow #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fixes branch ref for new build workflow #277

merged 1 commit into from
Nov 9, 2021

Conversation

foot
Copy link
Collaborator

@foot foot commented Nov 9, 2021 •
edited
Loading

New build workflow is a reusable workflow

Unfortunately for now you must provide a branch name when referencing them. From the above:

You reference reusable workflow files using the syntax:
{owner}/{repo}/{path}/{filename}@{ref}

This changes the branch ref from build-optimizations where it was developed in #264 to main where it will live on.

@foot foot added the test label Nov 9, 2021
sarataha
sarataha approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🙌

@foot foot merged commit 8631cc1 into main Nov 9, 2021
@foot foot deleted the correct-workflow-branch-now-its-on-main branch November 9, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarataha sarataha sarataha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @sarataha