Skip to content

Using chrome driver as web driver for macOS runner #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

Using chrome driver as web driver for macOS runner #275

merged 1 commit into from
Nov 9, 2021

Conversation

saeedfazal
Copy link
Contributor

@saeedfazal saeedfazal commented Nov 8, 2021 •
edited
Loading

  • Make UI acceptance tests to use chrome driver as webdriver because selenium server 4.0 is not compatible with agouti
  • Fixed failing upgrade test on EKS due to wrong upgrade cluster type

closes #271

@saeedfazal saeedfazal added the test label Nov 8, 2021
@saeedfazal saeedfazal self-assigned this Nov 8, 2021
foot
foot approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saeedfazal saeedfazal merged commit 72d85ea into main Nov 9, 2021
@saeedfazal saeedfazal deleted the fix_nightly_tests branch November 9, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix nightly CI jobs failing for EKS and GKE environment
2 participants
@saeedfazal @foot