Set cluster namespace #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
set-cluster-ns
branch
3 times, most recently
from
9bbf071 to
edadc78
Compare
yiannistri
force-pushed
the
set-cluster-ns
branch
2 times, most recently
from
3eec906 to
46a9f3c
Compare
yiannistri
force-pushed
the
set-cluster-ns
branch
from
46a9f3c to
439a46e
Compare
bigkevmcd
reviewed
Nov 8, 2021
| if os.Getenv("INJECT_PRUNE_ANNOTATION") != "disabled" { | ||
| opts = []capi.RenderOptFunc{capi.InjectPruneAnnotation()} | ||
| } | ||
| opts = append(opts, capi.InNamespace(os.Getenv("CAPI_CLUSTERS_NAMESPACE"))) |
There was a problem hiding this comment.
You could do something like this:
opts := []capi.RenderOptFunc{
capi.InNamespace(os.Getenv("CAPI_CLUSTERS_NAMESPACE"),
}
if os.Getenv("INJECT_PRUNE_ANNOTATION") != "disabled" {
append(opts, capi.InjectPruneAnnotation())
}But, I'd probably also make capi.InjectPruneAnnotation just be a func, rather than a func that returned a func.
- Only decode once - Flatten things out a bit, less fns returning fns - Don't override namespace if already set for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the namespace for all CAPI objects
Fixes #42