Skip to content

Revert "Support enabling verbose client-go logging" #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Jan 17, 2023

Reverts #1806

This breaks passing cli flags into the cluster-service e.g.

❯ go run cmd/clusters-service/main.go --dev-mode
{"level":"info","ts":1673961951.795032,"logger":"gitops","caller":"app/server.go:334","msg":"Setting klog verbosity","verbosity":"0"}
flag provided but not defined: -dev-mode
Usage of /var/folders/c_/ksp92k1j6m56l4l_p83t8jf00000gn/T/go-build3592919515/b001/exe/main:
  -add_dir_header
    	If true, adds the file directory to the header of the log messages
  -alsologtostderr
    	log to standard error as well as files (no effect when -logtostderr=true)
  -kubeconfig string
    	Paths to a kubeconfig. Only required if out-of-cluster.
  -log_backtrace_at value
    	when logging hits line file:N, emit a stack trace
  -log_dir string
    	If non-empty, write log files in this directory (no effect when -logtostderr=true)
  -log_file string
    	If non-empty, use this log file (no effect when -logtostderr=true)
  -log_file_max_size uint
    	Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
  -logtostderr
    	log to standard error instead of files (default true)
  -one_output
    	If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
  -skip_headers
    	If true, avoid header prefixes in the log messages
  -skip_log_headers
    	If true, avoid headers when opening log files (no effect when -logtostderr=true)
  -stderrthreshold value
    	logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
  -v value
    	number for the log level verbosity
  -vmodule value
    	comma-separated list of pattern=N settings for file-filtered logging
exit status 2

@foot foot marked this pull request as ready for review January 17, 2023 13:23
@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Jan 17, 2023
@foot foot requested a review from opudrovs January 17, 2023 13:26
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked! Great! 🎉

@foot foot merged commit 24171e5 into main Jan 17, 2023
@foot foot deleted the revert-1806-super-logging branch January 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants