Skip to content

Adds the gitopss-controller to WGE helm-chart #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 16, 2023
Merged

Adds the gitopss-controller to WGE helm-chart #2226

merged 5 commits into from
Jan 16, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Jan 16, 2023 •
edited
Loading

What changed?

Adds the gitopssets-controller to WGE helm chart and deploy it.

  • Its disabled by default
  • Its enabled in the Tiltfile

Why was this change made?

Gitopssets is a new controller we're adding to the product!

How was this change implemented?

cd ~/weave/gitopss-controller
make helm
cd ../weave-gitops-enterprise
helm dep update charts/mccp

How did you validate the change?

Tilt

Release notes

Documentation Changes

@foot
Adds the gitopss-controller to WGE helm-chart
2845381 
- Disabled by default for right now
- Update the Tiltfile to bring it up by default
@foot foot marked this pull request as ready for review January 16, 2023 12:22
@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Jan 16, 2023
ranatrk
ranatrk reviewed Jan 16, 2023
View reviewed changes
ranatrk
ranatrk approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@ranatrk ranatrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I started wge successfully with tilt, and gitopssets-controller deployed successfully

@foot foot merged commit df69d9e into main Jan 16, 2023
@foot foot deleted the adds-gitopssets-controller-to-chart branch January 16, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranatrk ranatrk ranatrk approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @ranatrk