Skip to content

Create secret Page #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jan 31, 2023
Merged

Create secret Page #2224

merged 36 commits into from
Jan 31, 2023

Conversation

AsmaaNabilBakr
Copy link
Contributor

@AsmaaNabilBakr AsmaaNabilBakr commented Jan 15, 2023

Closes #1934 #1934

What changed?

  • adding a page to create external secret PR
    Screenshot from 2023-01-16 13-39-36
    Screenshot from 2023-01-16 13-38-59

Why was this change made?
to make the creation of secrets more easy using UI

How was this change implemented?

How did you validate the change?
manual test

Release notes

Documentation Changes

@AsmaaNabilBakr AsmaaNabilBakr marked this pull request as ready for review January 16, 2023 12:17
@AlinaGoaga
Copy link
Contributor

Hey @AsmaaNabilBakr! Just wanted to mention that if you want to use callback state, you'll need the CallbackStateContextProvider which we use in AddResource and AddApplication also (we've got this in for Gitlab auth which, unlike Github, navigates the user away from the app page to Gitlab and then back). Cheers!

@TheGostKasper TheGostKasper requested review from AlinaGoaga and removed request for TheGostKasper January 17, 2023 12:00
@AlinaGoaga AlinaGoaga removed their request for review January 24, 2023 13:20
Copy link
Contributor

@ahussein3 ahussein3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!!

@ahussein3
Copy link
Contributor

ahussein3 commented Jan 30, 2023

I guess the backend stuff will need a review from someone else. @ahsayde , @serboctor

@serboctor
Copy link
Contributor

I guess the backend stuff will need a review from someone else. @ahsayde , @serboctor

Will take a look shortly

Copy link
Contributor

@serboctor serboctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsmaaNabilBakr AsmaaNabilBakr merged commit 8179f0a into main Jan 31, 2023
@AsmaaNabilBakr AsmaaNabilBakr deleted the create-secret branch January 31, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Secrets | Create New Secret
5 participants