[UI] Fix: error boundary does not allow user to navigate away from the page #2167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinaGoaga
changed the title
ahussein3
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1902
What changed?
Once error boundary kicked in, navigating away from the page had no effect, the user had to refresh the page to get access to the app again.
I've added a wrapper around the class component that we've got from the React docs to allow the use of useEffect which gives us the possibility to remove the error on location change
Sadly we can't use the Core component with a ContentWrapper page passed in which I had created, as the Core ErrorBoundary catches the error and displays it before it reaches the custom EE version which results in it not being displayed properly. It would be good to use the layout core components in EE as well, that would remove the issue
The changes have also made in core on PR weaveworks/weave-gitops#3205
How can we test it?
To test you can, for example, pass
nullinstead ofdata?.deploymentsin<FluxRuntime deployments={data?.deployments}/>