fixed tests failing due to templates rendering delay #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
force-pushed
the
test-refinment
branch
2 times, most recently
from
8af5182 to
264aa06
Compare
saeedfazal
added
exclude from release notes
saeedfazal
force-pushed
the
test-refinment
branch
from
264aa06 to
0e01d2e
Compare
saeedfazal
force-pushed
the
test-refinment
branch
from
0e01d2e to
b92974c
Compare
saeedfazal
force-pushed
the
test-refinment
branch
4 times, most recently
from
a454c21 to
fa836aa
Compare
saeedfazal
force-pushed
the
test-refinment
branch
from
fa836aa to
3b7548c
Compare
foot
reviewed
Dec 30, 2022
| @@ -59,6 +63,7 @@ spec: | |||
| namespace: ${{ .params.NAMESPACE }} | |||
| annotations: | |||
| templates.weave.works/create-request: "" | |||
| templates.weave.works/cluster-name: "${{ .params.CLUSTER_PATH }}" | |||
There was a problem hiding this comment.
👍 , makes sense, this is here as there seems to be a bug in extracting params from the path component right now.
saeedfazal
force-pushed
the
test-refinment
branch
from
2f29bcc to
9b0ae1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capd, leaf-cluster-tenant, leaf-cluster-gitopstemplate-deploy)Deploy: https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3805927176
Nightly: https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3805928938