Add Page to view secret details and secret events #2140
Conversation
…/weave-gitops-enterprise into 1953-view-secret-details
…/weave-gitops-enterprise into 1953-view-secret-details
…/weave-gitops-enterprise into 1953-view-secret-details
…/weave-gitops-enterprise into 1953-view-secret-details
…/weave-gitops-enterprise into 1953-view-secret-details
AsmaaNabilBakr
changed the title
| const ListEvents = (props: Props) => { | ||
| const { error, data, isLoading } = useListEvents(props); | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
What do you think if we can make use of WorkspaceTabsWrapper that we did in workspaces to use it here as well & maybe we can change the name to LoadingWrapper as it'll save us some duplicate code 🤔 ?
<WorkspaceTabsWrapper loading={isLoading} errorMessage={error?.message}>
<TableWrapper id="...">
<EventsTable events={data.events} />
...
| width: 100%; | ||
| `; | ||
| const DetailsHeadersWrapper = styled.div` | ||
| div { |
There was a problem hiding this comment.
Is it nested div > div to use it this way ?. If no, we can remove the div {
There was a problem hiding this comment.
yes i want to apply the style for the nested div div > div
| ]; | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
dev not needed here as CustomSubRouterTabs wrap what we need to return
| return ( | ||
| <div> | ||
| <CustomSubRouterTabs rootPath={`${path}/secretDetails`}> | ||
| <RouterTab name="Details" path={`${path}/secretDetails`}> |
There was a problem hiding this comment.
Can we change secretDetails to just details, or it may breaks something ?
| }, | ||
| ]; | ||
|
|
||
| console.log(secretDetails); |
|
|
||
| console.log(secretDetails); | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
<> not needed here as well
ui-cra/src/utils/nav.ts
Outdated
|
|
||
| Secrets= '/secrets', | ||
| Secrets = '/secrets', | ||
| SecretDetails = '/details' |
There was a problem hiding this comment.
/details can we change it /secrets/details or what do you think ?
Closes #1935 #1936
What changed?
Why was this change made?
to view more details about the secret and view the secret events list
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes