Skip to content

gitops run: Update Created column width and time format #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Dec 13, 2022

Closes #2068

The updated acceptance criteria:
#2068 (comment)

  • Added min width for the Created column of the GitOps Run sessions table (had to increase it a bit to fit the updated less than a minute ago string).
  • Added displaying less than a minute ago text if the formatted time contains seconds (it can only contain the largest units, so only like 5 minutes ago not 5 minutes and 30 seconds ago).
  • Pulled in the latest main from OSS.

Tested it, works as expected:

Screenshot 2022-12-14 at 13 37 12

Screenshot 2022-12-14 at 13 38 19

@opudrovs opudrovs added team/denim exclude from release notes Use this label to exclude a PR from the release notes area/gitops-run Anything related to GitOps Run labels Dec 13, 2022
@opudrovs opudrovs force-pushed the 2068-update-created-column-width-and-time-format branch from 03d2c7a to 5e4f1a9 Compare December 14, 2022 11:20
@opudrovs opudrovs marked this pull request as ready for review December 14, 2022 12:56
@opudrovs opudrovs requested review from joshri and foot December 14, 2022 13:02
@opudrovs opudrovs force-pushed the 2068-update-created-column-width-and-time-format branch from 2896866 to bb9eee2 Compare December 14, 2022 13:04
Add min width tot he Create column.

Pull in the latest `main` branch from WG OSS.
@opudrovs opudrovs force-pushed the 2068-update-created-column-width-and-time-format branch from bb9eee2 to b02845c Compare December 14, 2022 15:18
@opudrovs opudrovs merged commit 7a98800 into main Dec 14, 2022
@opudrovs opudrovs deleted the 2068-update-created-column-width-and-time-format branch December 14, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gitops-run Anything related to GitOps Run exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitops run: Update Created column width and time format
2 participants