Skip to content

Conversation

AsmaaNabilBakr
Copy link
Contributor

@AsmaaNabilBakr AsmaaNabilBakr commented Dec 13, 2022

Closes #1874 and #1873

What changed?
Workspaces List:

  • list all workspaces with its name, cluster name, and namespaces
  • you can sort with name
  • you can filter with name and cluster
  • you can navigate to details by clicking on name

Screenshot from 2022-12-01 14-38-27
Screenshot from 2022-12-01 14-38-51
Screenshot from 2022-12-01 14-39-17

Workspace Details:

  • create the workspace details page with tabs
  • each tab contains a table
  • you can search and filter with name
  • you can view yaml file

Screenshot from 2022-12-13 16-23-53
Screenshot from 2022-12-13 16-24-05
Screenshot from 2022-12-13 16-24-26
Screenshot from 2022-12-13 16-24-35

Why was this change made?

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@AsmaaNabilBakr AsmaaNabilBakr marked this pull request as ready for review December 13, 2022 15:06
@TheGostKasper
Copy link
Contributor

Hey @AsmaaNabilBakr , thanks for your effort in handing over the UI for the workloads, I'm worried about rewriting the tabs and yaml dialog while we already have both common components in our system to use and the TabDetails page is 🤯 we can split the code In several components to make it easier for us to follow, and the other thing with useState & fetching all request in the first init in the details tab makes the page slow and prone to multi renders which we can avoid.

Let's arrange a meeting to discuss it

Copy link
Contributor

@TheGostKasper TheGostKasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

The only concern is with Workspace List PR, we should close it as all the changes already in this PR .

@AsmaaNabilBakr AsmaaNabilBakr changed the title 1874 workspaces details 1874 workspaces List and details Dec 15, 2022
@AsmaaNabilBakr AsmaaNabilBakr merged commit d4ec941 into main Dec 19, 2022
@AsmaaNabilBakr AsmaaNabilBakr deleted the 1874-workspaces-details branch December 19, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspaces | View Workspace Details
3 participants