Skip to content

[UI/BE] Allow Git Repository selection for Git Authentication #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 114 commits into from
Jan 12, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Dec 12, 2022

Closes #1879

What changed?

  • GitAuth section displays a dropdown of git repos that the user has access to and allows the user to select the git repo to be used when the PR is created (this impacts create/delete cluster and create app)
  • If the git repo the user chooses is in ssh format, we convert it to https before adding it to the PR payload
  • For delete/edit cluster, we use the git repo url where the creation PR was added and disable the dropdown (for links that were initially ssh we convert them from https back to ssh to display)
  • If a git repo is annotated with ['weave.works/repo-rule'] : default it should appear as default in the dropdown; if this isn't present, the default will be the flux-system/flux-system gitrepo
  • BE was updated to use the repository Url sent in the create PR payload (it was before ignoring this and only using config values)
  • Cluster table has been updated to allow the selection of only one cluster as this is used solely for Delete Clusters which for the time being will only handle one cluster (handling multiple clusters would have been problematic since we can have different git repos where their PRs were initially created)

AlinaGoaga and others added 30 commits November 28, 2022 19:07
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AlinaGoaga AlinaGoaga merged commit 92839e6 into main Jan 12, 2023
@AlinaGoaga AlinaGoaga deleted the allow-repo-selection branch January 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DT,Dish][UI] As a User, I want to pick the GitRepo WGE is writing to so that I can use the repo structure that maps to my organisation
2 participants