Cleanup UI integration tests #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
added
exclude from release notes
saeedfazal
force-pushed
the
cleanup_ui_integration_tests
branch
2 times, most recently
from
e7f0a9d to
b955867
Compare
…nced outside of package
saeedfazal
force-pushed
the
cleanup_ui_integration_tests
branch
from
b955867 to
30be3f5
Compare
foot
reviewed
Dec 13, 2022
| @@ -379,6 +380,113 @@ func verifyCapiClusterHealth(kubeconfigPath string, applications []Application) | |||
| } | |||
| } | |||
|
|
|||
| // This function generates multiple template files from a single template to be used as test data | |||
| func generateTestTemplates(templateCount int, templateFile string) (templateFiles []string, err error) { | |||
There was a problem hiding this comment.
Did we remove some of the template "go-templates" recently? 🤔
There was a problem hiding this comment.
Yes, Now we have number of types of gitopsTemplate. Almost all tests use unique templates to test rather than multiple copies of same test.
We still have support of generating multiple templates form the templated template.
There is still one test which generate 50 templates from one template. It is still supported.
foot
reviewed
Dec 13, 2022
foot
approved these changes
Dec 13, 2022
AsmaaNabilBakr
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Deleted UI integration test directory * Deleted runner Describe from all specs * Delete all testrunner references and updated with standard function calls * Changed test-suite puplic functions to private as they are not referenced outside of package * Updated acceptance test lables because no more UI integration exclusion is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrationlabels as they are no longer required.Deploy: https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3658784672
Nightly: https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3659415510