Pendo Agent for Enterprise #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
force-pushed
the
1941-pendo-agent-for-enterprise
branch
3 times, most recently
from
0d7824e to
aaeacda
Compare
opudrovs
force-pushed
the
1941-pendo-agent-for-enterprise
branch
7 times, most recently
from
8c0768c to
d9742f5
Compare
|
Tested it locally, Pendo is initialized or not initialized properly. based on the value of the |
|
There's been a bit of churn, hopefully happier now, started a new run https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3631286250 |
opudrovs
force-pushed
the
1941-pendo-agent-for-enterprise
branch
from
77881d9 to
5544779
Compare
opudrovs
force-pushed
the
1941-pendo-agent-for-enterprise
branch
from
5544779 to
ef009ee
Compare
Add `WEAVE_GITOPS_FEATURE_TELEMETRY` to the dev values. Turn telemetry off for the acceptance testing workflow. Add the `Pendo` component. Add initializing telemetry. Add a check for the telemetry feature flag. Remove the unused `supportMultipleFlux` prop. Pull in the latest `main` branch from WG OSS.
opudrovs
force-pushed
the
1941-pendo-agent-for-enterprise
branch
from
ef009ee to
edc959f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1941
Removed unneeded checks when using feature flags.
Added
WEAVE_GITOPS_FEATURE_TELEMETRYto the dev values.Turned telemetry off for the acceptance and ui-integration testing workflow.
Added the
Pendocomponent from WG OSS.Added initializing telemetry (because in OSS it was moved out of a call to
NewCoreServer, so, now it must be called separately).Added a check for the telemetry feature flag.
Removed the unused
supportMultipleFluxprop (which probably became unused after one of the latest UI PRs in OSS).Pulled in the latest
mainbranch from WG OSS.Tested it locally, everything seems to work as expected.
Notes:
dev-values-local.yamlwith setting its value to thetruestring or just removing it from the dev value files (in enterprise. unlike OSS< telemetry is on by default unless it is explicitly set tofalsein the value files).Then you can run the following code in the browser console, to make sure that Pendo was or was not initialized as expected:
If telemetry is on, a Pendo object will be logged tot he console. If not, it should be undefined.