Add gitops run sessions #1952
Merged
Add gitops run sessions #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozamosi
force-pushed
the
run-sessions
branch
2 times, most recently
from
4cdb816 to
6821007
Compare
ozamosi
force-pushed
the
run-sessions
branch
from
6821007 to
bcdcaa5
Compare
opudrovs
approved these changes
Nov 25, 2022
ozamosi
force-pushed
the
run-sessions
branch
2 times, most recently
from
b007d1a to
9d1853f
Compare
added 2 commits
November 28, 2022 11:40
The application now grabs the management cluster from the single cluster fetcher from core, while the former multi-cluster now ignores the management cluster and instead just returns the gitopsclusters. I want to add another cluster fetcher that isn't tied to this fetcher, and this way they could be turned on and off independently from each other with feature flags.
This adds gitops run sessions as another source of available clusters. The clusters do not show up in the cluster tab, but their resources do show up in the applications/sources tabs.
ozamosi
force-pushed
the
run-sessions
branch
from
9d1853f to
a317777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on weaveworks/weave-gitops#3062.
This changes the multi fetcher to be a pure gitops cluster fetcher (named because it fetches objects of the kind GitopsCluster, other suggestions accepted) - instead of just using this fetcher to the cluster manager, this now uses both this fetcher and core's single (constant) cluster fetcher.
Then, it adds a second cluster fetcher for gitops run created vcluster instances. This looks a lot like the gitops cluster fetcher, except it pulls the clusters out of a statefulset instead of a CRD.
The result is that the automation shows up in the source and automation views, but not in the cluster view.
There's no rbac enabled in these clusters - it would really be preferable if the fetcher ran as the user in question so that they could only see the clusters in namespaces they had access to, but that would take another major refactoring of the cluster manager.
This extra cluster fetcher sits behind the same feature flag as the UI - it's on in tilt, off in releases.