-
Notifications
You must be signed in to change notification settings - Fork 2
Add turning analytics on during the first gitops CLI run #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6104bcf
to
0d1c4c9
Compare
Tested it locally, it looks like everything is working as expected. |
|
Makefile
Outdated
@@ -196,3 +197,4 @@ tools/core-files/charts/gitops-server/Chart.yaml: tools/core-files/Makefile.$(CO | |||
|
|||
echo-ldflags: tools/core-files/charts/gitops-server/Chart.yaml tools/core-files/Makefile.$(CORE_REVISION) | |||
@make --no-print-directory -f Makefile.core -C tools/core-files echo-ldflags VERSION="$(VERSION)-Enterprise-Edition-$(CORE_REVISION)" | |||
@make --no-print-directory -f Makefile.core -C tools/core-files echo-ldflags TIER="$(TIER)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the TIER variable to the end of the line above and only call make once - otherwise you'll over-write the version with the OSS version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Add the `TIER` LDFLAG.
0d1c4c9
to
bd75bc2
Compare
Closes weaveworks/weave-gitops#2843
Closes weaveworks/weave-gitops#2452
Closes #1622