Use /v1/charts/list in CLI
#1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarataha
force-pushed
the
cli-profile-listing-endpoint
branch
from
3433af0 to
9344919
Compare
sarataha
force-pushed
the
cli-profile-listing-endpoint
branch
2 times, most recently
from
cd85130 to
c3de052
Compare
sarataha
force-pushed
the
cli-profile-listing-endpoint
branch
from
c3de052 to
31ede5c
Compare
foot
reviewed
Nov 25, 2022
| @@ -773,6 +773,7 @@ message RepositoryChart { | |||
| // This is the available versions in reverse semver order. | |||
| repeated string versions = 2; | |||
| string layer = 3; | |||
| RepositoryRef repository = 4; | |||
There was a problem hiding this comment.
Don't need this I don't think?
There was a problem hiding this comment.
I added it at first because it was needed in add.go when calling GetProfile 🤔
There was a problem hiding this comment.
Gotcha! Yeah I stripped that bit actually 👍
foot
reviewed
Nov 25, 2022
pkg/services/profiles/add.go
Outdated
| @@ -38,7 +38,13 @@ func (s *ProfilesSvc) Add(ctx context.Context, r ProfilesRetriever, gitProvider | |||
| return fmt.Errorf("failed to get default branch: %w", err) | |||
| } | |||
|
|
|||
| helmRepo, version, err := s.discoverHelmRepository(ctx, r, GetOptions{ | |||
| // FIXME: should come from flags | |||
There was a problem hiding this comment.
Lets add some flags to fix this too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1907
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes