Reorganise testdata yamls for acceptance tests #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
added
exclude from release notes
saeedfazal
force-pushed
the
organize-testdata-yamls
branch
from
ce319ca to
e465306
Compare
saeedfazal
force-pushed
the
organize-testdata-yamls
branch
4 times, most recently
from
1b2bf9f to
8c7189a
Compare
saeedfazal
force-pushed
the
organize-testdata-yamls
branch
from
8c7189a to
d97d552
Compare
foot
reviewed
Nov 29, 2022
| @@ -225,7 +225,7 @@ jobs: | |||
| path: cmd/gitops/gitops-${{matrix.os}} | |||
| retention-days: 1 | |||
| - name: Configure AWS Credentials | |||
| if: ${{ (github.ref_name == 'main') && (github.event_name == 'push') }} | |||
| if: ${{ (github.ref_name == 'main') && (github.event_name == 'schedule') }} | |||
There was a problem hiding this comment.
Only need AWS creds for nightlies?
There was a problem hiding this comment.
yes, only nightlies are pushing the gitops binary to S3 once a day..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Restructure/reorganise test data file for better maintainability.
Why was this change made?
yamlsunder one location.GitOpsTemplate.How was this change implemented?
How did you validate the change?
https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/3531499643