Skip to content

Handle no Terraform controller CRD on leaf cluster #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2022
Merged

Handle no Terraform controller CRD on leaf cluster #1925

merged 3 commits into from
Nov 29, 2022

Conversation

jpellizzari
Copy link
Contributor

@jpellizzari jpellizzari commented Nov 21, 2022 •
edited
Loading

Closes #1887

Removes an error where a leaf cluster does not have TF installed.

@jpellizzari jpellizzari added the enhancement New feature or request label Nov 21, 2022
@jpellizzari jpellizzari marked this pull request as ready for review November 28, 2022 17:00
luizbafilho
luizbafilho reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@luizbafilho luizbafilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be possible to check by error message if is something related to the missing CRD?

@jpellizzari
Copy link
Contributor Author

jpellizzari commented Nov 28, 2022 •
edited
Loading

Wouldn't be possible to check by error message if is something related to the missing CRD?

Checking for a string in an error message seems problematic, as if the message text changes the behavior would break. Should I add a custom error type to the clustermngr package instead @luizbafilho ? That would require another release to take effect.

@luizbafilho
Copy link
Contributor

Checking for a string in an error message seems problematic, as if the message text changes the behavior would break. Should I add a custom error type to the clustermngr package instead @luizbafilho ? That would require another release to take effect.

yep, I think that would be better, although is annoying requiring releases but that is what we get for now. I'd prefer that to potentially hide errors.

@jpellizzari jpellizzari force-pushed the 1887-tf-404 branch 4 times, most recently from d0317b9 to d53c6ae Compare November 29, 2022 20:57
@jpellizzari jpellizzari merged commit ac46225 into main Nov 29, 2022
@jpellizzari jpellizzari deleted the 1887-tf-404 branch November 29, 2022 21:06
@jpellizzari jpellizzari mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@luizbafilho luizbafilho luizbafilho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwanted error message displayed for Terraform when missing on leaf clusters
2 participants
@jpellizzari @luizbafilho